feat: enable on key in join_asof#916
Merged
MarcoGorelli merged 2 commits intonarwhals-dev:mainfrom Sep 6, 2024
Merged
Conversation
MarcoGorelli
reviewed
Sep 6, 2024
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @raisadz , looks great! just one comment
narwhals/dataframe.py
Outdated
Comment on lines
+3579
to
+3608
| return super().join_asof( | ||
| other, left_on=left_on, right_on=right_on, strategy=strategy | ||
| ) | ||
| if left_on is not None and right_on is not None and on is not None: | ||
| msg = "Either (`left_on` and `right_on`) or `on` keys should be specified." | ||
| raise ValueError(msg) | ||
| if left_on is not None and right_on is not None: | ||
| return super().join_asof( | ||
| other, left_on=left_on, right_on=right_on, strategy=strategy | ||
| ) | ||
| elif on is not None: | ||
| return super().join_asof(other, on=on, strategy=strategy) | ||
| else: | ||
| msg = "Either (`left_on` and `right_on`) or `on` keys should be specified." | ||
| raise ValueError(msg) |
Member
There was a problem hiding this comment.
does this need updating, or can you also just defer to super().join_asof( here?
Contributor
Author
There was a problem hiding this comment.
thanks, updated this part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.